add socket tier 1 reachability analysis - #129
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a scheduled GitHub Actions workflow to run Socket’s “full application reachability” scan for this Rust repository, surfacing Tier 2 reachability fallbacks as a non-failing warning to keep CI signal actionable.
Changes:
- Introduces a new
socket-scan.ymlworkflow scheduled weekly (and runnable on demand). - Sets up Rust + Node, installs Socket CLI, and runs
socket scan create --reach, emitting a::warning::if Tier 2 reachability fallback markers appear.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Make the Node 24 env-var comment date-agnostic (2026-06-16 has passed) - Remove the unused Corepack step; this repo has no package.json, so it only ever shimmed yarn/pnpm that are never invoked - Replace dtolnay/rust-toolchain with `rustup update`, matching the convention in this repo's other Rust workflows and dropping a third-party action from a security workflow Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
It is now dead config, for two independent reasons: - Every action pinned in this workflow already declares `using: node24` in its action.yml, and the var only upgrades actions that declare node20 — so it had no effect here even before the cutover. - GitHub runners have defaulted to Node 24 since 2026-06-16, and Node 20 is fully removed on 2026-09-16. Note the var never silenced the node20 deprecation warnings either: the runner classifies an action from its declared version before consulting this var (actions/runner#4295). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
anupsdf
reviewed
Aug 28, 2026
anupsdf
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5689311233/Socket+Tier+1+Reachability+Analysis